Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/133 toggle defaults #134

Merged
merged 4 commits into from Feb 16, 2019
Merged

Conversation

lumio
Copy link
Collaborator

@lumio lumio commented Feb 13, 2019

As described in #133, the defaults of the toggle field were missing.

Additionally the source uses 2 spaces and not tabs, yet it was set to tabs for js files. Fixed that as well.

@terkelg
Copy link
Owner

terkelg commented Feb 15, 2019

Thank you so much @lumio. I'll have a look at this PR over the weekend. 👍

@terkelg terkelg merged commit edf5c41 into terkelg:master Feb 16, 2019
@terkelg
Copy link
Owner

terkelg commented Feb 16, 2019

Thank you so much. The issue was very detailed and the PR was just perfect. Let me know if you're interested in becoming a part of the prompts team and help maintain it.

@lumio lumio deleted the bugfix/133-toggle-defaults branch February 16, 2019 17:36
@lumio
Copy link
Collaborator Author

lumio commented Feb 16, 2019

I feel honoured, although I think it was just a very simple issue.

It sounds interesting to join your team. I’ll give you a text to discuss how this could look like

@lumio lumio restored the bugfix/133-toggle-defaults branch February 18, 2019 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants